Skip to content

Fix MinNonceLength for SecurityPolicies.Basic128Rsa15 #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrsuciu merged 1 commit into from
Dec 12, 2025
Merged

Fix MinNonceLength for SecurityPolicies.Basic128Rsa15 #3410

mrsuciu merged 1 commit into from
Dec 12, 2025

Conversation

@romanett
Copy link
Contributor

@romanett romanett commented Dec 11, 2025

Proposed changes

Set NonceLength to 16 for SecurityPolicies.Basic128Rsa15

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@romanett romanett requested a review from mrsuciu December 11, 2025 20:27
@codecov
Copy link

codecov bot commented Dec 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.93%. Comparing base (d25caff) to head (c614df1).
⚠️ Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
Stack/Opc.Ua.Core/Security/Certificates/Nonce.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3410      +/-   ##
==========================================
+ Coverage   51.86%   59.93%   +8.06%     
==========================================
  Files         370      377       +7     
  Lines       78618    78715      +97     
  Branches    13650    13709      +59     
==========================================
+ Hits        40779    47175    +6396     
+ Misses      33705    27167    -6538     
- Partials     4134     4373     +239

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrsuciu mrsuciu merged commit 1e6a043 into OPCFoundation:master Dec 12, 2025
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcschier marcschier marcschier approved these changes

@mrsuciu mrsuciu mrsuciu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to use Security Policy Basic128Rsa15

3 participants

@romanett @marcschier @mrsuciu